Generalize Hangprinter Anchors #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it gets too deep. I think there's an option in eclipse to forbid this by project in format, one can config depness iirc.
- jtimon's comments fixes - little compiler warning and error fixes
This is a clean generalization from 4 to N. Pseudo-pyramid because the vertices in the base of the pseudo-pyramid don't need to be on the same plane. There's no base of the pyramid as such. Better documented and cleaner thanks to @tobbelobb on github.
…etups - Change from bool to class and introduce None mode for custom (experimental) setups (all allowed) - refactor out IsInsidePyramidSides - refactor out IsInsidePrismSides - introduce HangprinterAnchorMode::LastOnTop for prism-like setups with all anchors on top - introduce a T parameter in M666 to configure the anchor mode
This allows to print square pyramids instead of tetrahedrons, at the cost of an extra motor. WIP: not everything is adapted after recent changes. See the newest TODOs
... for quadrilateral pyramid flex compensation
Fixes file not found "MessageFormats.h" error
tobbelobb
force-pushed
the
3.5-dev-generalize-hangprinter-anchors
branch
from
112391e
to
330c814
Compare
|
Rebased and added forward transform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one builds on top of #603, #601, #598, two own commits, #597, in that order. So it includes everything me and @jtimon have been working on, but also:
The algorithm has been developed in this repo: https://gitlab.com/tobben/hangprinter-flex-compensation, and copy-pasted into RRF and back again, so both are identical, and one of them has been plotted and visually inspected.
This PR will need some testing on hw before an eventual merge.
Me and @jtimon might work in different directions soon, so this is a good place for jtimon to find my most recent commits related to anchor generalization, as well as my testing status on hw.