-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge changes from the original repository #1
Changes from all commits
4f222e4
a215e52
b0fbb6f
a90172f
c9ac4c2
0a61bbc
f53d469
ecd44ed
c633688
918d3ad
91c16b9
488edd8
ec16672
618d245
a8c862f
ffd0d35
5b375ea
0f10d84
3750264
9438b4a
c432bc8
324d59f
e1d64e7
5ba0816
60e265a
4fa0f5d
8c9b38a
6f0a966
9f4de4f
e133990
09f6555
1aae2cc
0f021d9
6c592db
9450536
f9c08fa
fe2ed53
aeb303f
bf6c6f7
8cc55a6
c3be71e
e84dcf7
68ea193
ec92bd9
0f31799
a7bd485
6522fb2
460e1a1
0cbd97e
b850379
2dc2121
1ae9244
68dc046
471f69c
a46229f
6e87451
7f73084
e7869c4
5d1e989
18536ca
48d6668
d99eaa6
61ce9b4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
archiveVersion = 1; | ||
classes = { | ||
}; | ||
objectVersion = 52; | ||
objectVersion = 54; | ||
objects = { | ||
|
||
/* Begin PBXBuildFile section */ | ||
|
@@ -851,7 +851,6 @@ | |
CreatedOnToolsVersion = 7.3.1; | ||
DevelopmentTeamName = "Mixpanel, Inc."; | ||
LastSwiftMigration = 1020; | ||
ProvisioningStyle = Automatic; | ||
SystemCapabilities = { | ||
com.apple.ApplePay = { | ||
enabled = 0; | ||
|
@@ -1841,10 +1840,10 @@ | |
CODE_SIGN_ENTITLEMENTS = MixpanelDemo/MixpanelDemo.entitlements; | ||
CODE_SIGN_IDENTITY = "iPhone Developer"; | ||
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; | ||
CODE_SIGN_STYLE = Automatic; | ||
CODE_SIGN_STYLE = Manual; | ||
CURRENT_PROJECT_VERSION = 6; | ||
DEFINES_MODULE = YES; | ||
DEVELOPMENT_TEAM = E8FVX7QLET; | ||
DEVELOPMENT_TEAM = ""; | ||
INFOPLIST_FILE = MixpanelDemo/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
|
@@ -1899,8 +1898,12 @@ | |
buildSettings = { | ||
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES; | ||
CLANG_ENABLE_MODULES = YES; | ||
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; | ||
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "-"; | ||
CODE_SIGN_STYLE = Manual; | ||
DEVELOPMENT_TEAM = AXVA7A4XGX; | ||
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = ""; | ||
"DEVELOPMENT_TEAM[sdk=macosx*]" = ""; | ||
Comment on lines
+1901
to
+1906
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Build configuration inconsistency detected across targets There are inconsistent DEVELOPMENT_TEAM settings across different targets:
This partially aligns with the PR's objective, but the configuration needs to be consistent across all targets. 🔗 Analysis chainConfirm build configuration for all platforms. Development team settings have been cleared for both iOS and macOS targets. This change:
Let me gather more context about the build configurations to understand the complete picture. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for platform-specific build configurations
# Look for any remaining team IDs that might need to be cleared
rg "DEVELOPMENT_TEAM\s*=\s*[A-Z0-9]+"
Length of output: 300 Script: #!/bin/bash
# Get more context around the DEVELOPMENT_TEAM settings to understand which targets they belong to
rg "DEVELOPMENT_TEAM.*=.*" -B 5 -A 1 MixpanelDemo/MixpanelDemo.xcodeproj/project.pbxproj
Length of output: 1815 |
||
GCC_PREPROCESSOR_DEFINITIONS = ( | ||
"$(inherited)", | ||
"COCOAPODS=1", | ||
|
@@ -1928,6 +1931,8 @@ | |
buildSettings = { | ||
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES; | ||
CLANG_ENABLE_MODULES = YES; | ||
CODE_SIGN_STYLE = Manual; | ||
DEVELOPMENT_TEAM = ""; | ||
INFOPLIST_FILE = MixpanelDemoTests/Info.plist; | ||
LD_RUNPATH_SEARCH_PATHS = ( | ||
"$(inherited)", | ||
|
@@ -1937,6 +1942,7 @@ | |
LIBRARY_SEARCH_PATHS = "$(SRCROOT)/../Mixpanel"; | ||
PRODUCT_BUNDLE_IDENTIFIER = com.mixpanel.MixpanelDemoTests; | ||
PRODUCT_NAME = "$(TARGET_NAME)"; | ||
PROVISIONING_PROFILE_SPECIFIER = ""; | ||
SWIFT_COMPILATION_MODE = wholemodule; | ||
SWIFT_OBJC_BRIDGING_HEADER = ""; | ||
SWIFT_OPTIMIZATION_LEVEL = "-O"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Version bump introduces NSScreen/NSApplication usage that may affect DuetDaemon
The version update from 4.1.4 to 4.3.0 has reintroduced NSScreen and NSApplication usage that was previously commented out for daemon mode compatibility:
import Cocoa
in both filesAutomaticProperties.swift
MixpanelInstance.swift
These changes could cause issues with DuetDaemon during user logout as previously noted. Consider:
🔗 Analysis chain
Verify version bump compatibility with DuetDaemon
Given the significant version jump from 4.1.4 to 4.3.0 and the concerns about NSScreen/NSApplication affecting DuetDaemon during user logout, we should carefully verify the macOS-specific changes.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 569
Script:
Length of output: 1460
Script:
Length of output: 24761