Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#61): Add gallery page #108

Merged
merged 8 commits into from
Feb 25, 2022
Merged

feat(#61): Add gallery page #108

merged 8 commits into from
Feb 25, 2022

Conversation

stouffers
Copy link
Collaborator

close #61

tholulomo
tholulomo approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@tholulomo tholulomo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Noted a couple of things to discuss at tomorrow's call

@stouffers stouffers force-pushed the #61_Templated_View_-_Images branch from 5b324c3 to cc4bde6 Compare February 17, 2022 20:33
aswallace
aswallace approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@aswallace aswallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing was the pagination buttons responding to full-size windows

tholulomo
tholulomo reviewed Feb 21, 2022
View reviewed changes
Copy link
Contributor

@tholulomo tholulomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stouffers, I updated my review with a few suggestions.

aswallace
aswallace approved these changes Feb 24, 2022
View reviewed changes
Copy link
Collaborator

@aswallace aswallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can address URI handling in future ticket

@tholulomo
Copy link
Contributor

tholulomo commented Feb 25, 2022 •
edited
Loading

Can address URI handling in future ticket

If this fix won't be part of the current work done, @stouffers please go ahead and create a TD ticket for this. The ticket should be under this Epic #96.

@tholulomo tholulomo assigned tholulomo and stouffers and unassigned tholulomo Feb 25, 2022
@tholulomo tholulomo added the P1 🥇 Priority label Feb 25, 2022
@tholulomo tholulomo added this to the 2/14 - 2/28 milestone Feb 25, 2022
@stouffers stouffers force-pushed the #61_Templated_View_-_Images branch from 721a6b1 to 118faaf Compare February 25, 2022 23:09
@stouffers stouffers merged commit 5aa5888 into develop Feb 25, 2022
@tholulomo tholulomo deleted the #61_Templated_View_-_Images branch February 27, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswallace aswallace aswallace approved these changes

@tholulomo tholulomo tholulomo approved these changes

Assignees

@stouffers stouffers

Labels
P1 🥇 Priority
Projects
None yet
Milestone
2/14 - 2/28
Development

Successfully merging this pull request may close these issues.

Templated View - Images
3 participants
@stouffers @tholulomo @aswallace