#89 setup whyis docker container

[jpmccu]

Fixes #89.

[tholulomo]

Left few comments

[tholulomo]

Just noticed line 2 is a system install.

[tholulomo]

#accepted

[jpmccu]

It's actually installed in /opt/venv with everything else.

…

On Mon, Apr 4, 2022 at 4:31 PM tholulomo ***@***.***> wrote: ***@***.**** approved this pull request. #accepted ------------------------------ In whyis/Dockerfile.dev <#110 (comment)> : > -FROM ubuntu:20.04 as dependencies -RUN apt-get update && apt-get install -y software-properties-common gcc - -RUN apt-get update && apt-get install -y \ - python3.8-distutils \ - python3.8-dev \ - python3-pip \ - python3.8-venv \ - curl \ - libdb5.3-dev \ - default-jdk-headless -RUN python3.8 -m venv /opt/venv -RUN /opt/venv/bin/pip install requests>=2.27.1 wheel gunicorn -RUN /opt/venv/bin/pip install whyis==2.0b1 whyis-unit-converter==0.0.2 +FROM tetherlessworld/whyis:latest +RUN /opt/venv/bin/pip install whyis-unit-converter==0.0.2 WORKDIR '/app' I think WORKDIR '/app' should be in line 2 to ensure that Whyis unit converter is installed in the appropriate directory. Ignore if it's confirmed that the unit-converter is installed in the app dir — Reply to this email directly, view it on GitHub <#110 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAETCEJXNAXLWWTUYXSZ6SLVDNGS7ANCNFSM5OFPLZTA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Jamie McCusker (she/they) Director, Data Operations Tetherless World Constellation Rensselaer Polytechnic Institute ***@***.*** ***@***.***> http://tw.rpi.edu