#145: add parameterized query page #167
Conversation
app/src/pages/explorer/parameterized-query/parameterized-query-page.vue
Outdated
Show resolved
Hide resolved
| } | ||
| </script> | ||
|
|
||
| <style lang="scss" scoped> |
There was a problem hiding this comment.
I think we're still avoiding scoped styling (but we'll need to address cleaning up assets/css overall too)
There was a problem hiding this comment.
I would like to know why we are avoiding scoped styling. I don't see many downsides, and in this circumstance, the styles wouldn't apply to any other components.
There was a problem hiding this comment.
I honestly don't have a good answer for this, may be a question for @tholulomo once he's back. I know we're doing a big css refactor soon anyhow so likely could be left as is for now regardless and then treated as TD if it needs to be addressed later
| @@ -78,6 +85,15 @@ const explorerRoutes = [ | |||
| name: 'FacetFilterView', | |||
| component: () => import('@/pages/explorer/FacetFilter.vue'), | |||
| meta: { requiresAuth: false } | |||
| }, | |||
| { | |||
| path: 'parameterized_query', | |||
There was a problem hiding this comment.
This is a general question, not necessarily a request for a change here-- what's the preference on this project for - vs _ vs camelCase in our routes? I've noticed we have routes that use each of these
app/src/pages/explorer/parameterized-query/parameterized-query-page.vue
Outdated
Show resolved
Hide resolved
#145