Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161: Fix vega chart responsiveness #171

Merged
merged 5 commits into from
May 3, 2022

Conversation

aswallace
Copy link
Collaborator

fixes #161

Prevents chart from covering the description during responsive screen resizing
Also fixes bug where vega tooltips did not align with the chart

@aswallace aswallace linked an issue Apr 25, 2022 that may be closed by this pull request
@aswallace aswallace self-assigned this Apr 25, 2022
Copy link
Collaborator

@stouffers stouffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Not sure about nginx conf change.

nginx/default.conf Outdated Show resolved Hide resolved
Copy link
Contributor

@tholulomo tholulomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@aswallace aswallace merged commit 2286c4c into develop May 3, 2022
@aswallace aswallace deleted the #161_chart_overlap_on_small_screens branch May 3, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart overlap on small screens
3 participants