Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#241 metamine visualization tool #258

Merged
merged 25 commits into from
Oct 7, 2022
Merged

#241 metamine visualization tool #258

merged 25 commits into from
Oct 7, 2022

Conversation

aswallace
Copy link
Collaborator

MVP of visualization for 2D pixelated metamaterial unit cells.
Uses vega-lite to render the interactive chart, and Apollo GraphQL to pull the data.

TODO:

  • Replace symmetry color coding("c2v" and "c4v") with dataset names
  • Show elastic surfaces using the Python code shared by Wayne
  • Post data on QA

aswallace and others added 24 commits August 10, 2022 16:16
@aswallace
#241: MVP of metamaterial visualization tool
488e331 
Important TD: data access is very inefficient right now and needs lots of work

- csv needs to be stored on rest, not frontend
- should be stored in local storage after initial pull
- needs geometry visualization

Currently mockup2 is the more up-to-date version
@aswallace
#241: Add unit cell visualization for 10x10 and 50x50, fix screen resize
dc760b1
@aswallace
#241: Combine mockups but separate vega specification
bc6940c
@aswallace
#241: Remove mockup
2ed6240
@aswallace
#241: Make metamaterial unit cell scale based on number of pixels
38a4000
@aswallace
Linting errors
5788717
@tholulomo
#229: dataset curation
b1cd0f9
@aswallace
#241: Minor UI fixes, add loading spinner
95cf33e
@aswallace
Fix linting error
9c28bb6
@aswallace
#241: Metamaterial viz feedback
b842c9e 
- Add constituent material info under the unit cell image
- Temporarily switch to using Papaparse for csv to json conversion since my implementation was buggy
@tholulomo
#229: WIP
ffbf813
@tholulomo
#229: added a resolver for dataset upload
697413b
@tholulomo
#229: Add file upload and update data stream
2f3aafe
@tholulomo
#229: dataset unit testing
4516464
@aswallace
Merge branch '#229_Spreadsheet_file_interface' of https://github.com/…
f7b09cd 
…Duke-MatSci/materialsmine into #241_metamine_visualization_tool
@tholulomo
#252: Add resolver for pixelated data and updated unit test
4fb402d
@tholulomo
#252: Validate user before allowing upload
248e974
@tholulomo
#252: Linter fixes
a3044c3
@aswallace
Merge branch '#252_Pixelated_Data_Backend_Implementation' of https://…
dfacedd 
…github.com/Duke-MatSci/materialsmine into #241_metamine_visualization_tool
@tholulomo
#252: Re adding missing library
706c5f0
@aswallace
Merge branch '#252_Pixelated_Data_Backend_Implementation' of https://…
551c77a 
…github.com/Duke-MatSci/materialsmine into #241_metamine_visualization_tool
@aswallace
#241: Pixelated metamaterial viz updates
c68634b 
- Switch to using apollo graphql for data
- Temporarily remove color coding until datasets have label or title
- Temporarily limit to 10x10 OR 50x50, not both
- Add loading spinner, fix async behavior
@aswallace
Merge branch 'develop' of https://github.com/Duke-MatSci/materialsmine …
a60197a 
…into #241_metamine_visualization_tool
@aswallace
#241: Fix metamaterial viz unit tests
6c97e47
@aswallace aswallace self-assigned this Oct 6, 2022
@aswallace aswallace requested a review from tholulomo as a code owner October 6, 2022 20:06
@aswallace aswallace linked an issue Oct 6, 2022 that may be closed by this pull request
Metamine Visualization Tool #241
Closed
6 tasks
tholulomo
tholulomo approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@tholulomo tholulomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, if fixes will take longer for my comments, let's go ahead and merge. We can create a tech debt to fix later, especially the timeout with async in it to reduce latency.

@aswallace aswallace mentioned this pull request Oct 7, 2022
Closed
@aswallace aswallace merged commit f27dbb3 into develop Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholulomo tholulomo tholulomo approved these changes

Assignees

@aswallace aswallace

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metamine Visualization Tool
2 participants
@aswallace @tholulomo