Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metamine visualization tool: #259 combine timeouts #260

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Metamine visualization tool: #259 combine timeouts #260

merged 5 commits into from
Oct 17, 2022

Conversation

aswallace
Copy link
Collaborator

  • Combine the timeout calls into one function
  • Remove the unused vega-lite component (we're using a different method to embed the chart)
  • Remove width: 'container' from the vega spec -- doesn't actually affect width and causes a warning to be thrown

Using the same branch as the original PR

close #259

@aswallace aswallace self-assigned this Oct 12, 2022
tholulomo
tholulomo approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@tholulomo tholulomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aswallace aswallace merged commit dbedc83 into develop Oct 17, 2022
@tholulomo tholulomo deleted the #241_metamine_visualization_tool branch March 12, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholulomo tholulomo tholulomo approved these changes

Assignees

@aswallace aswallace

Labels
Technical Debt Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine Timeouts in Metamine Viz
2 participants
@aswallace @tholulomo