Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#292): update visualization image gallery #297

Merged
merged 7 commits into from
Mar 1, 2023
Merged

fix(#292): update visualization image gallery #297

merged 7 commits into from
Mar 1, 2023

Conversation

aswallace
Copy link
Collaborator

@aswallace aswallace commented Feb 9, 2023 •
edited
Loading

Addresses several image gallery bugs

  • Allows query parameters (page size, number, filter type, search term) to be passed in the uri of the gallery
  • Routing back from detail view preserves the query parameters
  • Page size and page number are limited
  • Page number can be entered as an input in Paginator component
  • Snackbar is triggered on network errors
  • Filter types are dropdown instead of radio
  • Fixed image pipeline capitalization sensitivity

Also adds features to Image Detail View

  • Image thumbnails no longer get squashed
  • DOI link in subheading
  • Author list in tabs
  • Button to search for other images in same doi (uses query params)
  • Clicking on keyword now searches for images with same keyword (uses query params)

Also updated unit tests and snapshot

closes #292

@aswallace aswallace self-assigned this Feb 9, 2023
@aswallace aswallace linked an issue Feb 9, 2023 that may be closed by this pull request
Visualization gallery UI bugs #292
Closed
3 tasks
tholulomo
tholulomo approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@tholulomo tholulomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's add the discuss updates and merge

@aswallace
fix(#292): modify page input and selection styling
f06ee22 
make the page number input smaller to match surrounding labels,
move the selection to the same line as buttons and match styling
@aswallace aswallace changed the title #292 visualization gallery UI bugs fix(#292): update visualization image gallery Mar 1, 2023
@aswallace aswallace merged commit c498b15 into develop Mar 1, 2023
@aswallace aswallace deleted the #292_visualization_gallery_ui_bugs branch March 1, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholulomo tholulomo tholulomo approved these changes

Assignees

@aswallace aswallace

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visualization gallery UI bugs
2 participants
@aswallace @tholulomo