Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#362 countdown page and drawer fix #363

Merged
merged 8 commits into from
Mar 22, 2023

Conversation

tholulomo
Copy link
Contributor

Fix the countdown page design bugs for smaller screens and also issues where users can still access the initial pages deployed on prod.

Updated the drawer and group menu links into appropriate sections.

closes #362

@tholulomo tholulomo requested a review from aswallace as a code owner March 22, 2023 17:37
@aswallace
Copy link
Collaborator

Noticing a slight misalignment for smaller screen sizes (I think it's tab-port, tab-land, or tablet, but can't quite tell)

Screen Shot 2023-03-22 at 10 44 47 AM

Copy link
Collaborator

@aswallace aswallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about alignment and a couple other non-essential suggestions. Also, I still think that transparent email field is a little hard to read

@tholulomo tholulomo merged commit 9d576b5 into develop Mar 22, 2023
@tholulomo tholulomo deleted the #362_Countdown_page_and_drawer_fix branch March 22, 2023 18:27
@github-actions
Copy link

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Countdown page and drawer fix
2 participants