Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#398 authentication bugs #399

Merged
merged 2 commits into from
May 31, 2023
Merged

#398 authentication bugs #399

merged 2 commits into from
May 31, 2023

Conversation

aswallace
Copy link
Collaborator

@aswallace aswallace commented May 26, 2023 •
edited
Loading

  • Added Edge to list of supported browsers
  • Made beforeEach re-route either back to the current route or to home depending on use case
  • Added links to our testing libraries in the README

fixes #398
closes #396
closes #288

@aswallace aswallace self-assigned this May 26, 2023
@aswallace aswallace requested a review from tholulomo as a code owner May 26, 2023 20:35
@aswallace aswallace linked an issue May 26, 2023 that may be closed by this pull request
Log in and Log out bugs #398
Closed
tholulomo
tholulomo approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@tholulomo tholulomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tholulomo tholulomo merged commit 2ba5670 into develop May 31, 2023
@tholulomo tholulomo deleted the #398_authentication_bugs branch May 31, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholulomo tholulomo tholulomo approved these changes

Assignees

@aswallace aswallace

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log in and Log out bugs Add testing link in the README Login redirect page
2 participants
@aswallace @tholulomo