Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Moved hasActiveReply ternary condition outside of the class #685

Conversation

zainab-a-ali
Copy link
Contributor

Fixes Issue

My PR closes #665

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

Moved the ternary condition outside of the className

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

Copy link

vercel bot commented Aug 26, 2024

@zainab-a-ali is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 26, 2024

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@zainab-a-ali Please fix this error, if you don't know how, try this:

  • Read the error carefully or read the contributing file
  • Checkout past merged Pull requests to see how they were done for it to be merged

Note: you can edit your PR message, this PR won't be merged if the error isn't gone and you have a week max to fix it before the PR gets closed without being merged

@zainab-a-ali zainab-a-ali changed the title Moved hasActiveReply ternary condition outside of the class refactor: Moved hasActiveReply ternary condition outside of the class Aug 26, 2024
@zainab-a-ali
Copy link
Contributor Author

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@zainab-a-ali Please fix this error, if you don't know how, try this:

  • Read the error carefully or read the contributing file
  • Checkout past merged Pull requests to see how they were done for it to be merged

Note: you can edit your PR message, this PR won't be merged if the error isn't gone and you have a week max to fix it before the PR gets closed without being merged

I have added 'refactor: ' to the title now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] define the hasActiveReply ternary condition outside of the class
2 participants