Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump mytoyota version to 2.1.4 #287

Closed
wants to merge 1 commit into from
Closed

Bump mytoyota version to 2.1.4 #287

wants to merge 1 commit into from

Conversation

ajain-93
Copy link
Contributor

Fixes #286

@ajain-93 ajain-93 mentioned this pull request Aug 14, 2024
Closed
@ajain-93
Copy link
Contributor Author

@DurgNomis-drol Can you review this PR to close #286?

@desosav
Copy link

desosav commented Aug 14, 2024

Just letting you know that there is already a PR that takes care of the manifest file https://github.com/DurgNomis-drol/ha_toyota/pull/257/files
Thank you for updating the mytoyota python module and bringing this integration back to life :)

CM000n
CM000n requested changes Aug 14, 2024
View reviewed changes
custom_components/toyota/manifest.json
@@ -7,6 +7,6 @@
"documentation": "https://github.com/DurgNomis-drol/ha_toyota",
"iot_class": "cloud_polling",
"issue_tracker": "https://github.com/DurgNomis-drol/ha_toyota/issues",
"requirements": ["mytoyota==2.1.1", "arrow"],
Copy link
Collaborator

@CM000n CM000n Aug 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we shouldn't pin the versions here anymore, but simply allow all non-major updates?
This would give us more freedom for patch and minor releases in the future and we would no longer have to wait for releases by @DurgNomis-drol.
So something like "mytoyota>=2.1.1,<3.0.0".

@CM000n
Copy link
Collaborator

CM000n commented Aug 14, 2024

Just letting you know that there is already a PR that takes care of the manifest file https://github.com/DurgNomis-drol/ha_toyota/pull/257/files Thank you for updating the mytoyota python module and bringing this integration back to life :)

Oh, that's right. There's already an MR from me :D I'm therefore closing this one as a duplicate.

@CM000n CM000n closed this Aug 14, 2024
@CM000n
Copy link
Collaborator

CM000n commented Aug 14, 2024

Dupliacte

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CM000n CM000n CM000n requested changes

Assignees
No one assigned
Labels
👥 duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stopped working completely on 8 August
3 participants
@ajain-93 @desosav @CM000n