Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark sensors as diagnostic #86

Merged
merged 4 commits into from
Nov 22, 2021
Merged

Conversation

rfvermut
Copy link
Contributor

Unclutters default lovelace view

image

@DurgNomis-drol
Copy link
Owner

Please make sure that all checks succeed. Run poetry run pre-commit run --all-files before commiting or to fix the errors that exists now and the push a new commit with these fixes 😊

@rfvermut
Copy link
Contributor Author

Oh, it opened a can of worms:

  And because homeassistant (2021.11.5) depends on httpx (0.19.0)
   and mytoyota (0.7.4) depends on httpx (>=0.18.1,<0.19.0), mytoyota (0.7.4) is incompatible with homeassistant (>=2021.11.1,<2022.0.0).
  So, because toyota depends on both homeassistant (^2021.11.1) and mytoyota (0.7.4), version solving failed.

@rfvermut
Copy link
Contributor Author

So depends on DurgNomis-drol/mytoyota#105

Copy link
Owner

@DurgNomis-drol DurgNomis-drol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entity_category is really not meant for integrations like this, though I like the initiative (Both yours and HA). Some sensors are straight forward, others like starter_battery_health would normally be in the diagnostic category, but in this instance it does not make sense. The same goes for some of those I made comments on below. As this is the first time we see this in HA, it is probably not in it's final form yet. This usually takes a couple of versions, so we will probably need to revisit this again.

custom_components/toyota/binary_sensor.py Outdated Show resolved Hide resolved
custom_components/toyota/binary_sensor.py Outdated Show resolved Hide resolved
custom_components/toyota/binary_sensor.py Outdated Show resolved Hide resolved
custom_components/toyota/entity.py Outdated Show resolved Hide resolved
@DurgNomis-drol
Copy link
Owner

Please rebase onto master, underlying issue with httpx has been fixed.

Copy link
Owner

@DurgNomis-drol DurgNomis-drol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing! 😃

pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Simon Hansen <67142049+DurgNomis-drol@users.noreply.github.com>
Copy link
Owner

@DurgNomis-drol DurgNomis-drol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for contributing! ❤️

@DurgNomis-drol DurgNomis-drol merged commit 950d3f4 into DurgNomis-drol:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants