-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark sensors as diagnostic #86
Conversation
Please make sure that all checks succeed. Run |
Oh, it opened a can of worms:
|
So depends on DurgNomis-drol/mytoyota#105 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entity_category
is really not meant for integrations like this, though I like the initiative (Both yours and HA). Some sensors are straight forward, others like starter_battery_health
would normally be in the diagnostic
category, but in this instance it does not make sense. The same goes for some of those I made comments on below. As this is the first time we see this in HA, it is probably not in it's final form yet. This usually takes a couple of versions, so we will probably need to revisit this again.
Please rebase onto master, underlying issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing! 😃
Co-authored-by: Simon Hansen <67142049+DurgNomis-drol@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for contributing! ❤️
Unclutters default lovelace view