Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude a few lines from coverage #143

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

joro75
Copy link
Collaborator

@joro75 joro75 commented Feb 12, 2022

These last few lines are very difficult to be tested with unittests, to excluded these 3 lines from the coverage statistics.
Based on the other unittests from the other Pull Requests, the total coverage should now be 100%, not including the controller.py file because that can only be tested with live communication with the toyota servers.

Copy link
Owner

@DurgNomis-drol DurgNomis-drol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🎉

Yes those are some edge cases that does not really matter.

@DurgNomis-drol DurgNomis-drol merged commit d0f77ca into DurgNomis-drol:master Feb 13, 2022
@joro75 joro75 deleted the NoCoverMarkings branch February 14, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants