-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include year and week as integers in statistical bucket data #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! What about the tests?
Yes, the unittests should indeed be modified too. |
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 94.64% 94.59% -0.05%
==========================================
Files 27 27
Lines 1325 1314 -11
==========================================
- Hits 1254 1243 -11
Misses 71 71
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The linter* now passes, i can merge this as administrator if need or we can wait for #147 is merged and trigger the action again? |
I have merged and triggered the action again. |
No problem! |
Fixes: #139: The 'year' information in the 'bucket' of the statistics is sometimes a string and sometimes an integer
The year and week are now always included as integers in the 'bucket' dictionary that is part of the driving statistics.