Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include year and week as integers in statistical bucket data #145

Merged
merged 4 commits into from
Feb 17, 2022

Conversation

joro75
Copy link
Collaborator

@joro75 joro75 commented Feb 13, 2022

Fixes: #139: The 'year' information in the 'bucket' of the statistics is sometimes a string and sometimes an integer

The year and week are now always included as integers in the 'bucket' dictionary that is part of the driving statistics.

DurgNomis-drol
DurgNomis-drol previously approved these changes Feb 14, 2022
Copy link
Owner

@DurgNomis-drol DurgNomis-drol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! What about the tests?

@joro75
Copy link
Collaborator Author

joro75 commented Feb 14, 2022

Yes, the unittests should indeed be modified too.
But to be able to do that, I first have to merge and finalize the PR #138, but that is facing some other problems.
I can probably fix that tomorrow.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #145 (632047d) into master (bbf5f3c) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   94.64%   94.59%   -0.05%     
==========================================
  Files          27       27              
  Lines        1325     1314      -11     
==========================================
- Hits         1254     1243      -11     
  Misses         71       71              
Flag Coverage Δ
unittests 94.59% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mytoyota/const.py 100.00% <ø> (ø)
mytoyota/statistics.py 100.00% <ø> (ø)
tests/test_myt.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf5f3c...632047d. Read the comment docs.

@DurgNomis-drol
Copy link
Owner

DurgNomis-drol commented Feb 17, 2022

The linter* now passes, i can merge this as administrator if need or we can wait for #147 is merged and trigger the action again?

@joro75
Copy link
Collaborator Author

joro75 commented Feb 17, 2022

I have merged and triggered the action again.
But it still requires a review again.... (sorry for that).

@DurgNomis-drol
Copy link
Owner

No problem!

@joro75 joro75 merged commit 078b48c into DurgNomis-drol:master Feb 17, 2022
@joro75 joro75 deleted the YearAsInt branch February 17, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'year' information in the 'bucket' of the statistics is sometimes a string and sometimes an integer
3 participants