Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PosixPath for path handling and create parent folders if they not exist #271

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

CM000n
Copy link
Collaborator

@CM000n CM000n commented Jan 3, 2024

This should fix an error if the parents of the CACHE_FILENAME do not exist in some environments.
See: #270

@CM000n CM000n self-assigned this Jan 3, 2024
@CM000n CM000n linked an issue Jan 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6e651ed) 72.46% compared to head (652cda1) 72.46%.

Files Patch % Lines
mytoyota/controller.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   72.46%   72.46%           
=======================================
  Files          28       28           
  Lines        1351     1351           
=======================================
  Hits          979      979           
  Misses        372      372           
Flag Coverage Δ
unittests 72.46% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CM000n CM000n added the 🐛 bug label Jan 3, 2024
@CM000n
Copy link
Collaborator Author

CM000n commented Jan 4, 2024

You should now have maintainer access @GitOldGrumpy 😊 Can you pls review this MR?

Copy link
Collaborator

@GitOldGrumpy GitOldGrumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@CM000n
Copy link
Collaborator Author

CM000n commented Jan 4, 2024

Looks good to me.

Strange, merging ist still blocked :-/
Can you please approve these changes @GitOldGrumpy?

Have you received and accepted the Maintainer invitation E-Mail?
You are still shown here as Contributor instead of Caollaborator.

@CM000n CM000n requested a review from GitOldGrumpy January 4, 2024 17:51
@GitOldGrumpy
Copy link
Collaborator

Looks good to me.

Strange, merging ist still blocked :-/ Can you please approve these changes @GitOldGrumpy?

Have you received and accepted the Maintainer invitation E-Mail? You are still shown here as Contributor instead of Caollaborator.

Yes I had seen the email, didn't realise I had to accept! I've done that now and it approved. Know cant merge because of open conversations.

@CM000n CM000n merged commit b178acc into master Jan 5, 2024
25 checks passed
@CM000n CM000n deleted the fix/cache_folder_creation_fails branch January 5, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache folder could not be set up.
3 participants