-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PosixPath for path handling and create parent folders if they not exist #271
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
=======================================
Coverage 72.46% 72.46%
=======================================
Files 28 28
Lines 1351 1351
=======================================
Hits 979 979
Misses 372 372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
You should now have maintainer access @GitOldGrumpy 😊 Can you pls review this MR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Strange, merging ist still blocked :-/ Have you received and accepted the Maintainer invitation E-Mail? |
Yes I had seen the email, didn't realise I had to accept! I've done that now and it approved. Know cant merge because of open conversations. |
This should fix an error if the parents of the CACHE_FILENAME do not exist in some environments.
See: #270