-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dynamic versioning #274
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #274 +/- ##
=======================================
Coverage 72.47% 72.47%
=======================================
Files 28 28
Lines 1355 1355
=======================================
Hits 982 982
Misses 373 373
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! Always thought to think about away to do this.
In my opinion, it means additional, actually unnecessary effort and causes potential errors that the package version number in
pyproject.toml
has to be adjusted each time to a version number matching the publishing tag. Also a separate MR has to be created every time for just bumping the version number in such manner.My suggestion would therefore be to use dynamic versioning: https://github.com/mtkennerly/poetry-dynamic-versioning
This uses the version number specified in the repository tag to build the python package each time during the
poetry build
process.