Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic versioning #274

Merged
merged 10 commits into from
Jan 5, 2024
Merged

Conversation

CM000n
Copy link
Collaborator

@CM000n CM000n commented Jan 5, 2024

In my opinion, it means additional, actually unnecessary effort and causes potential errors that the package version number in pyproject.toml has to be adjusted each time to a version number matching the publishing tag. Also a separate MR has to be created every time for just bumping the version number in such manner.

My suggestion would therefore be to use dynamic versioning: https://github.com/mtkennerly/poetry-dynamic-versioning
This uses the version number specified in the repository tag to build the python package each time during the poetry build process.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70526ac) 72.47% compared to head (4a3cc65) 72.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   72.47%   72.47%           
=======================================
  Files          28       28           
  Lines        1355     1355           
=======================================
  Hits          982      982           
  Misses        373      373           
Flag Coverage Δ
unittests 72.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@DurgNomis-drol DurgNomis-drol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Always thought to think about away to do this.

@DurgNomis-drol DurgNomis-drol merged commit ece873f into master Jan 5, 2024
25 checks passed
@CM000n CM000n deleted the enhancement/use_dynamic_versioning branch January 6, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants