Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make VehicleReponseModel values optional #307

Closed
wants to merge 2 commits into from

Conversation

CM000n
Copy link
Collaborator

@CM000n CM000n commented Jan 15, 2024

Interestingly, there are probably vehicles / accounts where the endpoints did not even return basic information to the car.
See DurgNomis-drol/ha_toyota#211

@CM000n CM000n self-assigned this Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c133e0) 70.50% compared to head (4cc1458) 70.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   70.50%   70.50%           
=======================================
  Files          30       30           
  Lines        1434     1434           
=======================================
  Hits         1011     1011           
  Misses        423      423           
Flag Coverage Δ
unittests 70.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CM000n
Copy link
Collaborator Author

CM000n commented Jan 16, 2024

Thx for the approval. I will wait with the merge till I get some more info from the User in the corresponding issue

@CM000n
Copy link
Collaborator Author

CM000n commented Jan 19, 2024

I am closing this because the error is not on our side.
The cause was probably a faulty/incomplete migration of the user vehicle to the new API: DurgNomis-drol/ha_toyota#211 (comment)

@CM000n CM000n closed this Jan 19, 2024
@CM000n CM000n deleted the fix/make_VehicleReponseModel_values_optional branch January 19, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants