Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add initial ServiceHistoryResponseModel #312

Merged
merged 13 commits into from
Jan 23, 2024

Conversation

CM000n
Copy link
Collaborator

@CM000n CM000n commented Jan 19, 2024

This PR introduces the ServiceHistoryResponseModel, which makes it possible to retrieve and display information about past vehicle services and inspections.

See also DurgNomis-drol/ha_toyota#222 and #311

@CM000n CM000n self-assigned this Jan 19, 2024
@CM000n CM000n marked this pull request as draft January 19, 2024 16:05
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (2c133e0) 70.50% compared to head (ad22204) 70.35%.

Files Patch % Lines
mytoyota/models/service_history.py 64.10% 14 Missing ⚠️
mytoyota/models/vehicle.py 26.66% 11 Missing ⚠️
mytoyota/api.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   70.50%   70.35%   -0.16%     
==========================================
  Files          30       32       +2     
  Lines        1434     1511      +77     
==========================================
+ Hits         1011     1063      +52     
- Misses        423      448      +25     
Flag Coverage Δ
unittests 70.35% <65.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CM000n CM000n linked an issue Jan 19, 2024 that may be closed by this pull request
@CM000n CM000n marked this pull request as ready for review January 22, 2024 09:55
@CM000n CM000n merged commit cea29b0 into master Jan 23, 2024
25 checks passed
@CM000n CM000n deleted the feature/add_service_history_endpoint branch January 23, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show inspections and service history
2 participants