Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I am owner of Toyota's EV, model BZ4X, it was useful for me to find this library already built. It was missing EV specific statuses that was already part of response. My guess is that BZ4X was not available for testing so it was not exposed in final output.
I added
ElectricStatus
model and populated attributes with information from payload. There were no need for many transformation from sourced data. I have tested library locally with different status on my car. Everything worked smoothly.These steps have been performed successfully:
poetry run pre-commit run --all-files
pytest tests/.
This is my first contribution to this project but I have plan to be active user, tester and contributor. Also my plan is to contribute to Home Assistant project https://github.com/DurgNomis-drol/ha_toyota in order to make these data useful for smart home automation.
As side note, this PR should solve question from here: #371