Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose electric status #379

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

dinorastoder
Copy link
Contributor

Since I am owner of Toyota's EV, model BZ4X, it was useful for me to find this library already built. It was missing EV specific statuses that was already part of response. My guess is that BZ4X was not available for testing so it was not exposed in final output.

I added ElectricStatus model and populated attributes with information from payload. There were no need for many transformation from sourced data. I have tested library locally with different status on my car. Everything worked smoothly.

These steps have been performed successfully:

  • ✔️ passed poetry run pre-commit run --all-files
  • ✔️ passed pytest tests/.

This is my first contribution to this project but I have plan to be active user, tester and contributor. Also my plan is to contribute to Home Assistant project https://github.com/DurgNomis-drol/ha_toyota in order to make these data useful for smart home automation.

As side note, this PR should solve question from here: #371

@dinorastoder
Copy link
Contributor Author

Hi @CM000n @DurgNomis-drol

I hope this PR is sent correctly. There is no option for requesting review or assigning it to someone from my side.

Cheers
Dino

@JohnnyTribi
Copy link

Thank you for your effort in extending the library for the bZ4X! Adding the ElectricStatus model to expose EV-specific statuses is a fantastic improvement. If this could be implemented in Home Assistant, it would be truly amazing and incredibly useful for smart home automation enthusiasts like myself.

Looking forward to seeing your contributions in the Home Assistant project. Many thanks again for your hard work and for sharing this!

@CM000n
Copy link
Collaborator

CM000n commented Jan 4, 2025

Hello @dinorastoder, thank you so much for your contribution and sorry for the late response. Unfortunately, the maintenance and development of the project is going slowly and laboriously for various "reasons".
I hope that I will soon find time to look at your changes.

@CM000n CM000n merged commit 425b933 into DurgNomis-drol:master Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants