-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build process: we should not be deleting build directories after a build - they are deleted beforehand anyway, and may contain useful info #1246
Labels
Comments
As a minor aside, the stage should be called "Notarise" .. I'll make the change to see if the build is successful .. and then change one rm at a time. |
dyaandys
added a commit
that referenced
this issue
Jul 12, 2024
dyaandys
added a commit
that referenced
this issue
Jul 12, 2024
dyaandys
added a commit
that referenced
this issue
Jul 12, 2024
dyaandys
added a commit
that referenced
this issue
Jul 12, 2024
…achine; use 'Ride' label to force build on mac2
dyaandys
added a commit
that referenced
this issue
Jul 12, 2024
dyaandys
added a commit
that referenced
this issue
Jul 12, 2024
…o removing trailing rm -Rfs in each stage
dyaandys
added a commit
that referenced
this issue
Jul 12, 2024
dyaandys
added a commit
that referenced
this issue
Jul 12, 2024
dyaandys
added a commit
that referenced
this issue
Jul 12, 2024
dyaandys
added a commit
that referenced
this issue
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At 0978c51
In Jenkinsfile we have
rm -rf _ ship
build_ride
stash ship
rm -rf _ ship
That last rm -rf is both unnecessary, and also unhelpful - if the builds thinks it's been successful but hasn't all the files will have been deleted which is unhelpful ! So let's delete that second rm -rf.
The text was updated successfully, but these errors were encountered: