Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Enter on a blank line makes cursor disappear #48

Closed
jayfoad opened this issue Jan 19, 2017 · 5 comments
Closed

Ctrl+Enter on a blank line makes cursor disappear #48

jayfoad opened this issue Jan 19, 2017 · 5 comments
Labels
Milestone

Comments

@jayfoad
Copy link
Contributor

jayfoad commented Jan 19, 2017

On Linux RIDE with a local spawned interpreter, if I hit Ctrl+Enter on a blank line in the session then the cursor disappears! I can still type into the session, but the cursor doesn't reappear until the next time I hit Enter.

IDE:
Version: unknown
Platform: Linux x86_64
Date: unknown
Git commit: unknown
Preferences:{
"favs":"[{"type":"start","ssh_auth_type":"pass","ssh_tnl_auth_type":"pass","exe":"apl"}]",
"kbdLocale":"en_GB",
"keys":"{"NX":["Shift-Ctrl-Right"]}",
"otherExe":"apl"
}

Interpreter:
Version: 16.0.29028
Platform: Linux-64
Edition: Unicode/64
Date: Jan 19 2017 at 14:17:27

@jayfoad
Copy link
Contributor Author

jayfoad commented Jan 19, 2017

N.B. In the ODE Ctrl+Enter on a blank line in the session will switch to an open tracer window if there is one, else do nothing. Dunno if RIDE needs to duplicate that behaviour.

@JasonRivers
Copy link
Member

I feel duplicating what the ODE does is a good idea, It's what people are most likely going to be used to, and this is one of those small things that people that don't use won't care and people that do use will want the behaviour to be the same.

@flouc001
Copy link
Contributor

flouc001 commented Jan 20, 2017

@jayfoad @JasonDyalog the cursor will no longer dissapear... working on switching to tracer.

@jayfoad
Copy link
Contributor Author

jayfoad commented Jan 23, 2017

working on switching to tracer

Thanks. There are actually two cases:

  1. If there is already a trace window open, switch to it, just like Ctrl+TAB would.
  2. If you are suspended but the tracer is not open yet, open it. This one has to work, because there is no other way to open the tracer in this situation.

A test case for (2): run the interpreter without TRACE_ON_ERROR=1, load dfns.dws, do "1 ⎕STOP'queens'" then "queens 4". At this point you'll be suspended in the "queens" function but the tracer won't be open yet.

@mkromberg mkromberg added this to the RIDE 4.0 milestone Feb 11, 2017
@e9gille e9gille added the SP2 label Feb 15, 2017
@flouc001 flouc001 added the P1 label Feb 16, 2017
@jayfoad jayfoad added P2 and removed P1 labels Feb 16, 2017
@e9gille
Copy link
Contributor

e9gille commented Feb 17, 2017

The 95badff commit fixes scenario (1) above. Not sure how to do (2)...

@e9gille e9gille closed this as completed in 4ff0573 Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants