Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Close All Windows menu item #51

Closed
jayfoad opened this issue Jan 25, 2017 · 4 comments
Closed

Add a Close All Windows menu item #51

jayfoad opened this issue Jan 25, 2017 · 4 comments

Comments

@jayfoad
Copy link
Contributor

jayfoad commented Jan 25, 2017

Add a "Close All Windows" menu item, perhaps on a new "Window" menu, to close all open editors tracers etc.

@jayfoad jayfoad added this to the RIDE 4.0 milestone Jan 25, 2017
@flouc001
Copy link
Contributor

flouc001 commented Feb 7, 2017

@jayfoad I'm assuming you want to terminate the connection and close the main RIDE window also?

@e9gille
Copy link
Contributor

e9gille commented Feb 9, 2017

@flouc001 I don't think he means the main window would be closed, only editors, trace and perhaps wse. Once we add a threads window that would presumably also need to be closed.

e9gille added a commit that referenced this issue Feb 9, 2017
@e9gille
Copy link
Contributor

e9gille commented Feb 9, 2017

The menu option closes all editor and trace windows, but I can see that the behavior differs to ODE with regards to closing the trace window. In ODE that keeps the stack, in RIDE it cuts the stack.

In ODE, closing the trace window with the X cuts the stack, but using the menu option doesn't. What is the expected behavior?

@e9gille e9gille added the SP2 label Feb 15, 2017
@flouc001 flouc001 added the P1 label Feb 16, 2017
@jayfoad jayfoad added P2 and removed P1 labels Feb 16, 2017
@jayfoad
Copy link
Contributor Author

jayfoad commented Feb 16, 2017

Needs a protocol message that RIDE can send, saying either:

  • close a window (but don't cut the stack), or
  • close all windows (but don't cut the stack).

@jayfoad jayfoad added P1 and removed P2 labels Feb 16, 2017
@e9gille e9gille closed this as completed in 1a453b1 Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants