Avoid an Option<Option<_>>

By simply swapping the calls to `map` and `and_then` around the complexity of handling an `Option<Option<_>>` disappears.
Dylan-DPC-zz · Apr 13, 2021 · 28aed81 · 28aed81
1 parent 2e7eb85
commit 28aed81
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/compiler/rustc_target/src/spec/mod.rs b/compiler/rustc_target/src/spec/mod.rs
@@ -1446,8 +1446,8 @@ impl Target {
 
         let get_req_field = |name: &str| {
             obj.find(name)
-                .map(|s| s.as_string())
-                .and_then(|os| os.map(|s| s.to_string()))
+                .and_then(Json::as_string)
+                .map(str::to_string)
                 .ok_or_else(|| format!("Field {} in target specification is required", name))
         };