Cross-platform tint color support

[millibeckers]

I needed this for a project that I was working on and it will also resolve this issue #124

[millibeckers]

Merged master and now passes CI

[millibeckers]

@DylanVann have you had a chance to give this a look to merge it in? I don't want to have to keep doing merges 😅

[ghost]

@DylanVann Any plans to merge this? We also need this functionality

[VinceBT]

@DylanVann Can you merge this ?

[Brianvdb]

@DylanVann Lets merge this Dylan

[stanvanheumen]

@DylanVann When is this scheduled to be merged?

[wfolini]

@DylanVann Any news about this?

[Brianvdb]

@DylanVann Any news?

[nehacs09]

@DylanVann What are the plans to merge this?

[barghi]

Hey guys do you have any plan to merge this ?

[stokesbga]

on iOS, resetting tintColor to null does not work, and instead persists the previously set tintColor.

[stokesbga]

if you add

- (void)setImageColor:(UIColor *)imageColor {
    if (imageColor != nil) {
        _imageColor = imageColor;
        super.image = [self makeImage:super.image withTint:self.imageColor];
    } else {
        super.image = _imageBackup;
    }
}

- (void)setImage:(UIImage *)image {
    if (self.imageColor != nil) {
        super.image = [self makeImage:image withTint:self.imageColor];
    } else {
        _imageBackup = image;
        super.image = image;
    }
}

then it works, but I dont like the idea of storing two copies...

[OlivierFreyssinet-old]

Is this gonna be merged soon ? Really need this 😁

[ericvicenti]

One day this will be merged and I will be able to migrate away from the fork 😂

https://www.npmjs.com/package/react-native-fast-image-with-tint-color

Edit: although, it looks like this PR adds tintColor as a prop. When really it should be a style prop.

[DimitryDushkin]

@DylanVann please?)

[Fabian-Fynn]

@DylanVann can we please merge this?

[Maddoc42]

Second that 👍

If a merge is not possible, @emilyjbeckers any chances we can hope for an updated version of your fork? v5.3.0 was recently released which addresses some memory issues on iOS (#433) 😇

[DylanVann]

I third that. @DylanVann please!

[DylanVann]

@emilyjbeckers, sorry it took so long, thank you!

[DylanVann]

@ericvicenti If this was made into a style prop we'd be forced to call https://facebook.github.io/react-native/docs/stylesheet#flatten on each render right? Wouldn't that be worse for performance, or is there another way you know of working it out?

[chrisfahy]

if this library could be maintained it would help my project considerably. i am a noob so cant help. only been programming 6 mths. but please know ppl use it and it was working amazingly

[DylanVann]

@chrisfahy This feature has been merged and released, check the releases page.

[chrisfahy]

i am having issues with memory pressure and am thinking its with fast image. any ideas for me? or can you recommend another library like this one? cheers for your time

[DylanVann]

You could try upgrading, a memory leak was fixed recently. Alternatively:

• Open a new issue with more information.
• Resize your images server side if they're too big.
• Use Image.
• Use native image loading libraries directly.

[chrisfahy]

Thank you @DylanVann. will try that this morning. i appreciate the help.