DYN-8121 SplashScreen Disable Close Button #15756
Conversation
Removing all the Dynamo code (including unit tests) that is used for the close SplashScreen functionality.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8121
|
GIF showing the expected behavior in SplashScreen (close button removed). |
|
|
||
| /// <summary> | ||
| /// [Obsolete] Constructor for ScriptObject | ||
| /// </summary> | ||
| [Obsolete] | ||
| public ScriptObject(Action<bool> requestLaunchDynamo, Action<string> requestImportSettings, Func< bool> requestSignIn, Func<bool> requestSignOut, Action requestCloseWindow) | ||
| public ScriptObject(Action<bool> requestLaunchDynamo, Action<string> requestImportSettings, Func< bool> requestSignIn, Func<bool> requestSignOut) |
There was a problem hiding this comment.
This is usually API breaking but I remember in the past we announced that we are not going to guard our UI code to follow backward compatible pattern. @mjkkirschner Correct me if I am wrong
|
Can you also check if any of the close action code to be removed here is used in DynamoRevit repo? |
In a ECS machine with Revit 2026.0.0_20250111 and Dynamo 3.5.0 (DYN-8121-SplashScreen-Disable-CloseButton-Dynamo branch) I replaced the references DynamoCore.dll and DynamoCoreWpf.dll generated by Dynamo solution in the DynamoRevit.csproj (just in this one) and compiled successfully DynamoRevit but when trying opening SplashScreen in Revit 2026 it didn't finish loading (not sure if is due that the dll were debug or if I have to replace all the Dynamo dlls generated in all DynamoRevit projects), not sure if this is enough or if you know another way to test this please let me know. Thanks
|
|
Changes look good but need to check if that is an API break or not. |
|
Please update the version of SplashScreen in this PR as well |
Updating the SplashScreen version to be consumed
Updated in the next commit: 841d756 |
|
Thank you @RobertGlobant20 There are some failures on the PR checks about declared APIs not found because of your removal, can you fix it? e.g. Symbol 'Dynamo.UI.Views.ScriptObject.CloseWindow() -> void' is part of the declared API, but is either not public or could not be found |
Fixing deleted public API (the deleted methods were inside SplashScreen.xaml.cs then shouldn't be considered as public API).
|
@avidit I bet we need your help updating one of the test closing splash screen as it used to support. For now, I will merge this one |
Purpose
Removing all the Dynamo code (including unit tests) that is used for the close SplashScreen functionality.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Removing all the Dynamo code (including unit tests) that is used for the close SplashScreen functionality.
Reviewers
@QilongTang
FYIs