-
Notifications
You must be signed in to change notification settings - Fork 648
DYN-6634 Update About Box content to move the license information to an online file #15846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6634
wait, was removal of the rtf file the only change here? |
I did not remove the rtf file, but updated its content. I had to remove majority of the content, but there is still a few lines in there, as seen in the screenshot. |
Gotcha @zeusongit , before we totally scratch them, would you paste them into the licence.txt file to and check if the txt file was missing any updates? |
Yes, done. |
@@ -81,48 +81,10 @@ https://github.com/MartinTopfstedt/FontAwesome5/blob/master/LICENSE | |||
MIT License | |||
Copyright (c) 2018 MartinTopfstedt | |||
|
|||
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks valid since it was repeated above at line 72
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE | ||
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is moved below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than two comments, look good to me
Purpose
This change will update the contents of the About Box, now we will have much shorter content that will offer links to the actual license file in the Git repository. Going forward, this change will be conducted with each release, as each release version should have a license file link pointing to its specific RC branch file.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Reviewers
@DynamoDS/dynamo