Skip to content

DYN-6634 Update About Box content to move the license information to an online file #15846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

zeusongit
Copy link
Contributor

Purpose

This change will update the contents of the About Box, now we will have much shorter content that will offer links to the actual license file in the Git repository. Going forward, this change will be conducted with each release, as each release version should have a license file link pointing to its specific RC branch file.

Screenshot 2025-02-20 at 4 44 42 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Update About Box content to move the license information to an online file

Reviewers

@DynamoDS/dynamo

@zeusongit zeusongit added this to the 3.5 milestone Feb 20, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6634

@QilongTang
Copy link
Contributor

wait, was removal of the rtf file the only change here?

@zeusongit
Copy link
Contributor Author

wait, was removal of the rtf file the only change here?

I did not remove the rtf file, but updated its content. I had to remove majority of the content, but there is still a few lines in there, as seen in the screenshot.

@QilongTang
Copy link
Contributor

Gotcha @zeusongit , before we totally scratch them, would you paste them into the licence.txt file to and check if the txt file was missing any updates?

@zeusongit
Copy link
Contributor Author

Gotcha @zeusongit , before we totally scratch them, would you paste them into the licence.txt file to and check if the txt file was missing any updates?

Yes, done.

@@ -81,48 +81,10 @@ https://github.com/MartinTopfstedt/FontAwesome5/blob/master/LICENSE
MIT License
Copyright (c) 2018 MartinTopfstedt

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks valid since it was repeated above at line 72

OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is moved below

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than two comments, look good to me

@zeusongit zeusongit merged commit bd08a21 into DynamoDS:master Feb 24, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants