DYN-8609: GroupBySimilarity node minor update #16034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8609
reddyashish
reviewed
Mar 31, 2025
src/Libraries/CoreNodes/List.cs
Outdated
| bool isNumeric = firstElementType == typeof(int) || firstElementType == typeof(float) || firstElementType == typeof(double) || firstElementType == typeof(long); | ||
| bool isString = firstElementType == typeof(string); | ||
|
|
||
| if (isNumeric && list.Cast<object>().Any(item => !(item is int || item is float || item is double))) |
reddyashish
reviewed
Mar 31, 2025
| @@ -462,8 +462,8 @@ | |||
| "ScaleFactor": 1.0, | |||
| "HasRunWithoutCrash": true, | |||
| "IsVisibleInDynamoLibrary": true, | |||
| "Version": "3.5.0.8100", | |||
| "RunType": "Manual", | |||
| "Version": "3.6.0.6885", | |||
There was a problem hiding this comment.
When cherrypicking this to 3.5 master, this version field needs to be changed?
reddyashish
approved these changes
Mar 31, 2025
reddyashish
approved these changes
Mar 31, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
(cherry picked from commit 82f9158)
9 tasks
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update GroupBySimilarity node to only allow lists as inputs with only numbers or only strings but not both.
Update max string tolerance value to 10.
Update node help docs
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/eidos