Exculde template view during View3d wrapping #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return null; |
There was a problem hiding this comment.
I am hesitate to wrap template 3dViews to whatever since that wrapping seems to always success that we might wrapped them to wrong dynamo types without the right query from IsPerspective(). I am returning null, as a result, they will appear "null" in the list of watch node. let me know if this is a bad idea.
QilongTang
changed the title
| // ElementsOfCategories & Views, as output of Categories | ||
| // passed to ElementsOFCategory | ||
| var elementsOfViewNodeID = "2569434a-b34f-4512-a4fe-f065c7a10175"; | ||
| AssertPreviewCount(elementsOfViewNodeID, 33); |
There was a problem hiding this comment.
Add a new case filtering out all views in the sample.rvt, since template views will appear null, by pass the null check.
|
LGTM |
This was referenced Sep 1, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
MAGN-5431 All Elements Of Type throws exception when handling views. Calling IsPerspective() on 3Dviews with IsTemplate marked as true will return exception instead of true/ false. This is idea but waiting for Revit API guild to response the reason behind that. As an attempt to fix on our side, we should avoid such query on template views so the graph can still execute. Added such case in unit tests so we could catch it when it's broken again later.
Declarations
Check these if you believe they are true
*.resxfilesNew results filtering out views:
Reviewers
@sm6srw
FYIs
@mjkkirschner