[DYN-7334] Revised TuneUp controls layout #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix sorting add datagrids
TODO: - Remove executionOrder from TotalGroupNodes - ExportJSON - write the code - Total time to be calculated from rounded times - Remove ExecutionTimes from NotExecuted nodes - UI to update when a node is renamed - UI to update when group is renamed and/or background color has changed
reddyashish
reviewed
Sep 16, 2024
| RaisePropertyChanged(nameof(OriginalName)); | ||
| } | ||
| } | ||
| public bool IsGroupExecutionTime |
There was a problem hiding this comment.
Add summary to this public property
reddyashish
reviewed
Sep 16, 2024
| @@ -18,7 +18,6 @@ public class TuneUpViewExtension : ViewExtensionBase, IViewExtension | |||
|
|
|||
| public override void Dispose() | |||
| { | |||
| TuneUpView.Dispose(); | |||
There was a problem hiding this comment.
Any reason to removing the dispose on the view when the extension is closed?
There was a problem hiding this comment.
AFAICT it was only unsubscribing from DynamoWindow_SizeChanged, which is not needed anymore.
reddyashish
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
PR to address DYN-7334
Revised layout as in Figma
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
@reddyashish
FYIs
@Amoursol
@dnenov