Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-2316] implement GitHub actions to publish librarie js npm package for every release #213

Conversation

Enzo707
Copy link
Contributor

@Enzo707 Enzo707 commented Mar 28, 2024

This PR includes Github Actions build and npm-publish for package management uses and remove deployment step in pipeline to ditch Nuget package management.

Review:
@QilongTang

@QilongTang
Copy link
Contributor

QilongTang commented Mar 28, 2024

Please also update the package name in package.json and package-lock.json, please use @dynamods/librarieJS

@Enzo707 Enzo707 force-pushed the DYN-2316/add-github-actions-to-publish-librarieJS-npm-package-after-every-release branch from 62fb6d4 to 885f941 Compare March 28, 2024 17:29
@Enzo707
Copy link
Contributor Author

Enzo707 commented Mar 28, 2024

Please also update the package name in package.json and package-lock.json, please use @dynamods/librarieJS

Done!

@@ -1,5 +1,5 @@
{
"name": "dynamo-hosted-contents",
"name": "@dynamods/librarieJS",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Enzo707 Also it looks like there is no version info here so publish would not work correctly. You can use version 1.0.0

Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@QilongTang QilongTang merged commit 58def74 into DynamoDS:master Mar 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants