Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRi#4958: Update DR to eliminate DR blocks #2439

Merged
merged 1 commit into from
Nov 23, 2021
Merged

DRi#4958: Update DR to eliminate DR blocks #2439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dynamorio
Open in desktop
Submodule dynamorio updated 104 files
5 changes: 0 additions & 5 deletions tests/framework/umbra_client_insert_app_to_shadow.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,11 +259,6 @@ event_app_instruction(void *drcontext, void *tag, instrlist_t *ilist, instr_t *w

if (!instr_reads_memory(where) && !instr_writes_memory(where))
return DR_EMIT_DEFAULT;
/* XXX: Workaround for DRi#4958 where DR code shows up in blocks
* and DR can't handle a fault there.
*/
if (dr_memory_is_dr_internal(dr_fragment_app_pc(tag)))
return DR_EMIT_DEFAULT;

if (subtest == UMBRA_TEST_1_C || subtest == UMBRA_TEST_2_C) {
for (i = 0; i < instr_num_srcs(where); i++) {
Expand Down