Skip to content

Commit

Permalink
Fix build
Browse files Browse the repository at this point in the history
  • Loading branch information
abhinav92003 committed Jan 24, 2025
1 parent 7a61b92 commit e59ce2b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions clients/drcachesim/tools/common/decode_cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
* decode_cache.h: Library that supports operations related to decoding trace
* instructions that are common to various trace analysis tools, including:
* - providing the address where the instr encodings are present, which can
* either be from the instr #memref_t for traces with embedded encodings, or
* either be from the instr memref_t for traces with embedded encodings, or
* from the mapped app binaries otherwise;
* - decoding the instr raw bytes to create the #instr_t;
* - caching of data derived from the decoded #instr_t, and updating the cache
Expand Down Expand Up @@ -446,8 +446,8 @@ template <class DecodeInfo> class decode_cache_t : public decode_cache_base_t {
* \p module_file_path also if they deliberately need to use the module mapper
* instead of the embedded encodings. Each instance of
* #dynamorio::drmemtrace::decode_cache_t must be initialized with either an
* empty \p module_file_path or the same one as all other instances (even the
* ones in other analysis tools).
* empty \p module_file_path, or the same one as other instances that also
* specified a non-empty path (even the ones in other analysis tools).
*
* If the provided \p module_file_path is empty, the cache object uses
* the encodings embedded in the trace records.
Expand Down
2 changes: 1 addition & 1 deletion clients/drcachesim/tools/opcode_mix.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ opcode_mix_t::init_decode_cache(shard_data_t *shard, void *dcontext,
} else {
shard->error = shard->decode_cache->init(filetype);
}
return err.empty().
return shard->error.empty();
}

std::string
Expand Down
2 changes: 1 addition & 1 deletion clients/drcachesim/tools/view.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ view_t::parallel_shard_memref(void *shard_data, const memref_t &memref)
}

// XXX: We could potentially use decode_cache_t here (i#7113) and avoid the
// repeated caching logic.
// duplicated caching logic.
app_pc decode_pc;
const app_pc orig_pc = (app_pc)memref.instr.addr;
if (TESTANY(OFFLINE_FILE_TYPE_ENCODINGS, filetype_)) {
Expand Down

0 comments on commit e59ce2b

Please sign in to comment.