Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code_api|tool.drcachesim.filter fails on AArch32 #2533

Closed
fhahn opened this issue Jul 13, 2017 · 5 comments
Closed

code_api|tool.drcachesim.filter fails on AArch32 #2533

fhahn opened this issue Jul 13, 2017 · 5 comments
Labels
Component-DrMemtrace OpSys-ARM OpSys-Linux

Comments

@fhahn
Copy link
Contributor

fhahn commented Jul 13, 2017

It fails during the nightly builds on a machine with a native AArch32 Linux. The generated output does not match the expected pattern. It looks like the following additional lines are generated:

    Prefetch hits:                       0
    Prefetch misses:                    21

http://dynamorio.org/CDash/testDetails.php?test=318024&build=26311
@egrimley
Copy link
Contributor

No, I think the problem is "application exited with code 11" and no "Hello, world!".

@fhahn
Copy link
Contributor Author

fhahn commented Jul 13, 2017

Agreed!

@egrimley
Copy link
Contributor

I think this failure (and #2532) is caused by DynamoRIO not realising that ADC reads C. I'll make a patch later.

I wonder how many similar bugs lurk. Is finding these included under #1686?

@egrimley egrimley mentioned this issue Jul 13, 2017
Closed
egrimley pushed a commit that referenced this issue Jul 14, 2017
@egrimley-arm
i#2533 ADC SBC RSC: Add to decode tables that these read carry flag.
9d23a5e 
The instructions ADC, ADCS, RSC, RSCS, SBC and SBCS read the carry
flag. The ones ending with S also set NZCV.

Fixes #2533

Change-Id: Ifc171d28fa13f510aefe37de7ba7e41487815d9c
@egrimley egrimley mentioned this issue Jul 14, 2017
Merged
egrimley pushed a commit that referenced this issue Jul 14, 2017
@egrimley-arm
i#2533 ADC SBC RSC: Add to decode tables that these read carry flag. (#…
d4b444f 
…2535)

The instructions ADC, ADCS, RSC, RSCS, SBC and SBCS read the carry
flag. (It was already correctly recorded that ADCS, RSCS and SBCS
write N, Z, C and V.)

Fixes #2533
@fhahn
Copy link
Contributor Author

fhahn commented Jul 17, 2017

Confirmed fixed by latest nightly build http://dynamorio.org/CDash/viewTest.php?onlyfailed&buildid=26473

@fhahn
Copy link
Contributor Author

fhahn commented Jul 17, 2017

Thanks Edmund!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component-DrMemtrace OpSys-ARM OpSys-Linux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fhahn @derekbruening @egrimley