Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install zlib on Windows GA CI #5767

Open
derekbruening opened this issue Nov 26, 2022 · 1 comment
Open

Install zlib on Windows GA CI #5767

derekbruening opened this issue Nov 26, 2022 · 1 comment
Labels
Component-Build OpSys-Windows

Comments

@derekbruening
Copy link
Contributor

The weekly package build is broken and also the CI builds apparently by a GS Windows image update which enabled zlib which was not there before.

Xref #5766

The comment here has some details and analysis: #5766 (comment)

The broken package build from this week: https://github.com/DynamoRIO/dynamorio/actions/runs/3551887463/jobs/5966427587

Dr. Memory's package build is also broken: https://github.com/DynamoRIO/drmemory/actions/runs/3551911682/jobs/5966473881
@derekbruening derekbruening mentioned this issue Nov 26, 2022
Merged
@prasun3 prasun3 mentioned this issue Nov 28, 2022
Merged
derekbruening pushed a commit that referenced this issue Nov 30, 2022
@cmannett85-arm
i#5767: Fix vs2019 pre-commit failures relating to zlib warnings (#5766)
1f40176 
Adds casts to satisfy vs2019 warnings-as-errors relating
to lossy implicit integer conversions.

Disables zlib for WIN32 AND AUTOMATED_TESTING to unblock the suite.
We should re-enable once we have proper zlib package identification
and installation on the GA CI machines.

Co-authored-by: Derek Bruening <bruening@google.com>

Issue: #5767
derekbruening added a commit that referenced this issue Nov 30, 2022
@derekbruening
i#5767: Disable zlib on windows package builds
2ea3fdf 
Works around issues with strawberry perl zlib on GA CI package
builders by disabling zlib by setting AUTOMATED_TESTING for package
builds, just like we're doing for testing on GA CI.

Issue: #5767
@derekbruening derekbruening mentioned this issue Nov 30, 2022
Merged
derekbruening added a commit to DynamoRIO/drmemory that referenced this issue Dec 1, 2022
@derekbruening
Fix VS2019 warnings in drcachesim
b9ab1b8 
Updates DR to 1f40176ae to fix VS2019 warnings.

Issue: DynamoRIO/dynamorio#5767
@derekbruening derekbruening mentioned this issue Dec 1, 2022
Merged
derekbruening added a commit to DynamoRIO/drmemory that referenced this issue Dec 1, 2022
@derekbruening
Fix VS2019 warnings in drcachesim (#2474)
d4b9a40 
Updates DR to 1f40176ae to fix VS2019 warnings.
Sets AUTOMATED_TESTING to enable settings in the DR build.

Issue: DynamoRIO/dynamorio#5767
derekbruening added a commit that referenced this issue Dec 1, 2022
@derekbruening
i#5767: Disable zlib on windows package builds (#5769)
8f6f478 
Works around issues with strawberry perl zlib on GA CI package
builders by disabling zlib by setting AUTOMATED_TESTING for package
builds, just like we're doing for testing on GA CI.

Issue: #5767
@derekbruening
Copy link
Contributor Author

We have temporarily disabled zlib on Windows when AUTOMATED_TESTING is set.

Longer-term we should install our own zlib and ensure the zlib-using tests all pass on Windows.

@derekbruening derekbruening changed the title GA Windows package and CI builds broken by zlib errors Install zlib on Windows GA CI Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component-Build OpSys-Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derekbruening