Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#2221: ignore private combase.dll entry failure #2226

Merged
merged 3 commits into from
Feb 26, 2017

Conversation

derekbruening
Copy link
Contributor

On win10, a private combase.dll's entry fails, but ignoring it lets at
least simple clients continue with no visible problems, so we go with
that for now.

This fixes the client.loader test on recent Windows versions.

On win10, a private combase.dll's entry fails, but ignoring it lets at
least simple clients continue with no visible problems, so we go with
that for now.

This fixes the client.loader test on recent Windows versions.
@derekbruening
Copy link
Contributor Author

Failure is nondet #1369:

code_api|client.drmgr-test =>  Application C:\projects\dynamorio\build\build_debug-internal-32\suite\tests\bin\client.drmgr-test.exe (6092).  Internal Error: DynamoRIO debug check failure: C:\projects\dynamorio\core\translate.c:817 false 

@derekbruening derekbruening merged commit 8477c9e into master Feb 26, 2017
@derekbruening derekbruening deleted the i2221-combase-entry branch February 26, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant