Clarify instr_is_cti() docs and make them cross-platform #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instr_is_cti() docs listed some x86 opcodes, implying it was not cross-platform. It also failed to list OP_ret. We change it here to generalize and make it cross-platform. We also update the docs for a few other related routines that are x86-specific.
|
appveyor failure is #1369: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instr_is_cti() docs listed some x86 opcodes, implying it was not
cross-platform. It also failed to list OP_ret. We change it here to
generalize and make it cross-platform. We also update the docs for a few
other related routines that are x86-specific.