i#2360: consistently label nzcvqg as arithmetic on ARM #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DR considers the Q and GE flags to be arithmetic for saving, restoring, and
in the EFLAGS_ARITH constant, yet not in the EFLAGS_{READ,WRITE}_ARITH
defines. We correct that here by including them in all arithmetic
defines.
Re-enables the drreg test that was broken because of this.
Relaxes a drreg assert on re-spilling to the aflags slot with different
regs, which is exposed by this fix. This relaxation mirrors what we
already do on restoring aflags.
Fixes #2360
|
appveyor failure is api.detach #2246 again: grrr. |
mikelui
pushed a commit
to VANDAL/dynamorio-sigil2
that referenced
this pull request
Apr 25, 2017
DR considers the Q and GE flags to be arithmetic for saving, restoring, and
in the EFLAGS_ARITH constant, yet not in the EFLAGS_{READ,WRITE}_ARITH
defines. We correct that here by including them in all arithmetic
defines.
Re-enables the drreg test that was broken because of this.
Relaxes a drreg assert on re-spilling to the aflags slot with different
regs, which is exposed by this fix. This relaxation mirrors what we
already do on restoring aflags.
Fixes DynamoRIO#2360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DR considers the Q and GE flags to be arithmetic for saving, restoring, and
in the EFLAGS_ARITH constant, yet not in the EFLAGS_{READ,WRITE}_ARITH
defines. We correct that here by including them in all arithmetic
defines.
Re-enables the drreg test that was broken because of this.
Relaxes a drreg assert on re-spilling to the aflags slot with different
regs, which is exposed by this fix. This relaxation mirrors what we
already do on restoring aflags.
Fixes #2360