Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#2371: fix native exec regression on gateway vs entry checks #2378

Merged
merged 2 commits into from
Apr 21, 2017

Conversation

derekbruening
Copy link
Contributor

Split off the uses of is_native_pc() as a test for targets that should
not re-takeover as a new routine is_stay_native_pc(). Use of
dr_app_running_under_dynamorio() was broken in the presence of non-empty
native_exec_areas by 6a8d7d2, causing its execution to go native.

Fixes #2371

Split off the uses of is_native_pc() as a test for targets that should
not re-takeover as a new routine is_stay_native_pc().  Use of
dr_app_running_under_dynamorio() was broken in the presence of non-empty
native_exec_areas by 6a8d7d2, causing its execution to go native.

Fixes #2371
Copy link
Contributor

@zhaoqin zhaoqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbruening derekbruening merged commit 96ea594 into master Apr 21, 2017
@derekbruening derekbruening deleted the i2371-native-exec-gateway branch April 21, 2017 19:04
derekbruening added a commit that referenced this pull request Apr 21, 2017
Split off the uses of is_native_pc() as a test for targets that should
not re-takeover as a new routine is_stay_native_pc().  Use of
dr_app_running_under_dynamorio() was broken in the presence of non-empty
native_exec_areas by 6a8d7d2, causing its execution to go native.

Fixes #2371
mikelui pushed a commit to VANDAL/dynamorio-sigil2 that referenced this pull request Apr 25, 2017
…RIO#2378)

Split off the uses of is_native_pc() as a test for targets that should
not re-takeover as a new routine is_stay_native_pc().  Use of
dr_app_running_under_dynamorio() was broken in the presence of non-empty
native_exec_areas by 6a8d7d2, causing its execution to go native.

Fixes DynamoRIO#2371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants