Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#1569 AArch64: In encoder/decoder, use all bits provided by pattern. #2517

Merged
merged 2 commits into from
Jul 11, 2017

Conversation

egrimley
Copy link
Contributor

Make all bits provided by the instruction pattern available to the
operand encoders and decoders, as originally intended. Previously
we were only making those bits available which were not handled by
any operand, which is usually the same thing, but occasionally a
proper subset of what was intended.

Change-Id: I5b7b51b56f3cf488d8753112dd840a706fe5b760

Make all bits provided by the instruction pattern available to the
operand encoders and decoders, as originally intended. Previously
we were only making those bits available which were not handled by
any operand, which is usually the same thing, but occasionally a
proper subset of what was intended.

Change-Id: I5b7b51b56f3cf488d8753112dd840a706fe5b760
@egrimley egrimley requested a review from fhahn July 10, 2017 11:43
@fhahn
Copy link
Contributor

fhahn commented Jul 10, 2017

Can one of the admins verify this patch?

@derekbruening
Copy link
Contributor

Can one of the admins verify this patch?

@fhahn -- are you doing something to auto-generate this message on every single pull request?

@fhahn
Copy link
Contributor

fhahn commented Jul 10, 2017

@fhahn -- are you doing something to auto-generate this message on every single pull request?

I'm currently trying to set up a jenkins instance for AArch64/AArch32 tests. Unfortunately initially it was configured to add a comment to all PR's that were not created by me, asking for an admin to trigger the build. I think I've changed that now.

Conflicts:
	core/arch/aarch64/decode_gen.h
	core/arch/aarch64/encode_gen.h

Change-Id: I4cd92e49b75ee745ff19f54b3878a2ed17bde950
Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egrimley egrimley merged commit 69913cb into master Jul 11, 2017
@egrimley egrimley deleted the i1569-opnd_bits branch July 11, 2017 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants