i#2144: better patch for single step with sandboxing #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/arch/mangle_shared.c
Outdated
| dcontext->single_step_addr = NULL; | ||
| instr_t * last_addr = instr_get_next_app(instr); | ||
| /* Checks if sandboxing added another app instruction. */ | ||
| if (!last_addr || last_addr->translation != instr->translation) { |
There was a problem hiding this comment.
style: last_addr == NULL
derekbruening
approved these changes
Aug 2, 2017
|
Appveyor failure is drmgr-test #1369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last patch worked fine for single step execution in normal mode.
But it does not work when dynamorio uses at the same time sandboxing.
Because sandboxing and single step both use special exit, there was a confusion.
When a basic block is built, sandboxing is inserted before mangling, which is used to modify special exit reason.
But, sandboxing adds another cti (not a meta app) in case there was a self-modification in the basic block.
So, this patch checks that only the last app instruction at single step address will be mangled