i#4066: patch out sysenter on x86_64 #4069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run arm tests |
derekbruening
requested changes
Jan 31, 2020
derekbruening
approved these changes
Jan 31, 2020
|
@derekbruening is that a new failure? No mention of it when I did a quick issue search on GitHub |
|
Okay added. Will you go ahead and merge, or do I run again hoping all goes green please? |
|
Thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the use of sysenter when building on x86_64 in order to avoid compilation errors.
The use of the sysenter gateway is most likely never used on 64-bit. Therefore, patching out sysenter should be okay.
Fixes #4066