i#4219 xl8: Add an rstat on synch xl8 failures #4228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an rstat "synchs_not_at_safe_spot" measuring the count of synch_with_thread attempts that had to be re-tried due to the target being suspended at an un-translatable (i.e., unsafe) spot. Adds a corresponding dr_stats_t field "synchs_not_at_safe_spot" for extraction. These will be useful for measuring the impact of clean calls and other un-translatable places on detach and other synch operations. Issue: #4219
|
Appveyor is a test that appears flaky, under #4058 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an rstat "synchs_not_at_safe_spot" measuring the count of
synch_with_thread attempts that had to be re-tried due to the target
being suspended at an un-translatable (i.e., unsafe) spot.
Adds a corresponding dr_stats_t field "synchs_not_at_safe_spot" for
extraction.
These will be useful for measuring the impact of clean calls and other
un-translatable places on detach and other synch operations.
Issue: #4219