i#4083 func view: Allow for 7-digit thread id in func_view tests #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After an upgdate, my machine has 7-digit thread id's, causing the func_view tests to fail. Here I widen the printed field and update the expected output for the stored trace. Issue: #4083
abhinav92003
approved these changes
Sep 28, 2020
|
The Travis failure is on Mac and is rather puzzling. I'm assuming it's unrelated to this PR and it's a Travis XCode upgrade or sthg? But Mac built for PR #4453 just prior to this. |
|
I re-ran just the Mac job and the error went away...?!? Well unfortunately we do not have resources to figure out strange non-reproducible issues like that. Moving on. |
This was referenced Sep 29, 2020
derekbruening
added a commit
that referenced
this pull request
Sep 29, 2020
After an upgdate, my machine has 7-digit thread id's, causing the func_view tests to fail. Here I widen the printed field and update the expected output for the stored trace. Issue: #4083
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an upgdate, my machine has 7-digit thread id's, causing the
func_view tests to fail. Here I widen the printed field and update
the expected output for the stored trace.
Issue: #4083