Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#4549: Finalize package building and docs deployment #4620

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

derekbruening
Copy link
Contributor

Fixes a few issues with the script added in PR #4612:

  • Splits the a64 and a32 builds into separate jobs, as package.cmake doesn't support both at once.
  • Fixes minor issues.

Tested via a manual launch with filled-in version and build and it worked:

Issue: #4549

@derekbruening
Copy link
Contributor Author

Failure is histogram.offline in 64-bit: it's already on the list for 32-bit for #4621. I'll add it to the list separately (or maybe part of PR #4623).

@derekbruening
Copy link
Contributor Author

@abhinav92003
Copy link
Contributor

I also updated https://github.com/DynamoRIO/dynamorio/wiki/New-Release#trigger-a-package-build

I'm not sure if anyone could trigger a manual build before, but is that acceptable? Do we need to somehow restrict this action to only admins?

@derekbruening
Copy link
Contributor Author

I also updated https://github.com/DynamoRIO/dynamorio/wiki/New-Release#trigger-a-package-build

I'm not sure if anyone could trigger a manual build before, but is that acceptable? Do we need to somehow restrict this action to only admins?

I think it's ok to allow any regular committer who has write access to the repository to trigger a new posted build? Before any dev could trigger as well by going to the Travis manual trigger page using Github credentials.

@derekbruening derekbruening merged commit 427ff3a into master Dec 15, 2020
@derekbruening derekbruening deleted the i4549-ga-package-fix branch December 15, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants