i#4487: inline instr count for trace_after_instrs in drcachesim, AArch64 #4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inlines instruction counting for the -trace_after_instrs option in drcachesim on AArch64 to avoid doing a clean call and thus improve performance. It involves enabling drx_insert_counter_update() for 64-bit counters for AArch64. Extends two tests with checks for 64-bit counter updates on AArch64. Fixes: #4487
|
@AssadHashmi -- If you could add @sapostolakis to the list for auto-triggering the aarch64 Jenkins. Though I thought any project member would trigger? |
|
run arm tests |
Added @sapostolakis to AArch64 CI Jenkins ACL.
Not yet. It's a manual process ATM. |
…rchXX-64-bit-counters
sapostolakis
commented
Jan 31, 2021
derekbruening
approved these changes
Feb 1, 2021
sapostolakis
added a commit
that referenced
this pull request
Feb 10, 2021
sapostolakis
added a commit
that referenced
this pull request
Feb 17, 2021
Revert certain x86-related changes from #4677. In particular, we avoid restoring the arithmetic flags and (if used) the scratch register before the call to `hit_instr_count_threshold`, which might not return. This fix is necessary but it seems to be causing failures in `drcachesim.delay-global` and `drcacheoff.max-global` on x86-64 CI testing. These failures are not reproducible outside CI testing and are (so far) inexplicable based on manual analysis of the instrumented assembly code (see #4711 (comment)). Thus, we are leaving x86_64 as technically broken to keep our tests green until the source of instability is found. Issue: #4711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlines instruction counting for the
-trace_after_instrsoption in drcachesim onAArch64 to avoid doing a clean call and thus improve performance.
Involves enabling
drx_insert_counter_update()for 64-bit counters for AArch64.Extends two tests with checks for 64-bit counter updates on AArch64.
Fixes: #4487