i#4698 detach_state: Port signal + GPR-cache tests to A64 #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables api.detach_state on AArch64 with some initial the sub-tests enabled: + Enables the cross-platform signal state tests on AArch64. + Ports the assembly to push and pop all the general-purpose registers, fill them with sentinel values, and test them on a detach from the code cache. As part of this, adds some general assembly support: + @p@ expands to # in cpp2asm. + Adds REG_SP and JUMP_NOT_EQUAL cross-platform asm_defines. + Adds a missing dep on detach_state_shared.h for the asm code. Still left to do for future work: + Check SIMD registers. + Check flags. + Check stack. + Detach from DR rather than the cache. Issue: #4698
|
The failures are all what looks like a bug in clang-format-diff where it disagrees with clang-format on the |
…rmat-diff problem
abhinav92003
approved these changes
Feb 4, 2021
|
Failure is burst_static callback.c assert which is #4486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables api.detach_state on AArch64 with some initial the sub-tests enabled:
registers, fill them with sentinel values, and test them on a detach
from the code cache.
As part of this, adds some general assembly support:
Still left to do for future work:
Issue: #4698