Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#3348 sym conflicts: Rename set_cache_size to proc_set_cache_size #5276

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

derekbruening
Copy link
Contributor

Fixes a symbol conflict with a python package PyTables that is hit
when statically linking with certain toolchains where non-exported
symbol hiding is not available. The fix is to rename set_cache_size()
to proc_set_cache_size(). This also matches the proc_ prefix for
related functions, so we do not resort to the d_r_ prefix.

Issue: #3348

Fixes a symbol conflict with a python package PyTables that is hit
when statically linking with certain toolchains where non-exported
symbol hiding is not available.  The fix is to rename set_cache_size()
to proc_set_cache_size().  This also matches the proc_ prefix for
related functions, so we do not resort to the d_r_ prefix.

Issue: #3348
@derekbruening derekbruening merged commit adcc46a into master Jan 11, 2022
@derekbruening derekbruening deleted the i3348-rename-set-cache-size branch January 11, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants