Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i#2626: AArch64 v8 decode: Fix incorrect decode of add/s, sub/s, tb(n)z #5282

Merged
merged 2 commits into from
Jan 14, 2022
Merged

i#2626: AArch64 v8 decode: Fix incorrect decode of add/s, sub/s, tb(n)z #5282

merged 2 commits into from
Jan 14, 2022

Conversation

joshua-warburton
Copy link
Collaborator

@joshua-warburton joshua-warburton commented Jan 14, 2022 •
edited
Loading

This patch fixes two underlying issues:

  • Several of the instruction variants were decoding to an x register
    when they should have been decoding to a w register
  • LSL # 12 was being decoded as 0x10 (16) rather than 0x0c (12)

issues: #2626

@joshua-warburton
i#2626: AArch64 v8 decode: Fix incorrect decode of add/s, sub/s, tb(n)z
33a29a3 
This patch fixes two underlying issues:
 * Several of the instruction variants were decoding to an x register
   when they should have been decoding to a w register
 * LSL #12 was being decoded as 0x10 (16) rather than 0x0c (12)

issues: #2626

Change-Id: I833b5693feee3208a54d94c15bfd3c22913a465d
@AssadHashmi AssadHashmi self-requested a review January 14, 2022 12:36
@joshua-warburton
clang format
1f2b798 
Change-Id: I929dc0d8f9433801f98ef53453eab537963bf9d1
@joshua-warburton
Copy link
Collaborator Author

run arm tests

@joshua-warburton joshua-warburton merged commit 247e98c into master Jan 14, 2022
@joshua-warburton joshua-warburton deleted the i2626-aarch64-fix-adds-subbs-tbz branch January 14, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AssadHashmi AssadHashmi AssadHashmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshua-warburton @AssadHashmi